Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugInfoView shouldn't use NO_BACKGROUND as style for Browser (regression in Eclipse 2021-03) #1477

Closed
msternermxy opened this issue Mar 26, 2021 · 1 comment · Fixed by #1639

Comments

@msternermxy
Copy link
Contributor

The BugInfoView in the Eclipse plug-in sets the SWT.NO_BACKGROUND style on its Browser instance, but the documentation for the Composite class says that the use of this style bit is undefined outside Canvas subclasses. This use has led to a regression when using the SpotBugs Eclipse plug-in in Eclipse 2021-03. The problem is that SWT.NO_BACKGROUND overlaps with the new constant SWT.EDGE for using the experimental WebView2 browser component on Windows (see Bug 572208 for SWT), and if that component is not available you get an exception:

org.eclipse.swt.SWTError: Not implemented [WebView2 runtime not found]
	at org.eclipse.swt.SWT.error(SWT.java:4915)
	at org.eclipse.swt.browser.Edge.createEnvironment(Edge.java:154)
	at org.eclipse.swt.browser.Edge.create(Edge.java:180)
	at org.eclipse.swt.browser.Browser.<init>(Browser.java:99)
	at de.tobject.findbugs.view.BugInfoView.createBrowser(BugInfoView.java:189)

It seems like the fix would be simple: use SWT.NONE when creating the Browser in the BugInfoView.

@welcome
Copy link

welcome bot commented Mar 26, 2021

Thanks for opening your first issue here! 😃
Please check our contributing guideline. Especially when you report a problem, make sure you share a Minimal, Complete, and Verifiable example to reproduce it in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants