Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gulp-watch to avoid polling for changes #37

Merged
merged 2 commits into from Dec 2, 2019

Conversation

@jtomschroeder
Copy link
Contributor

jtomschroeder commented Dec 2, 2019

Issue Link: CR-11203

Description

When running ace in a docker container, I've noticed the docker.hyperkit process shooting to 400% CPU. After some digging, I found that it's due to gulp.watch polling the filesystem directly instead of listening to FS events. I've replaced gulp.watch with the gulp-watch package, which uses inotify and solves the polling issue.

@jtomschroeder jtomschroeder requested a review from spothero/frontend as a code owner Dec 2, 2019
@jtomschroeder

This comment has been minimized.

Copy link
Contributor Author

jtomschroeder commented Dec 2, 2019

Copy link
Contributor

reintroducing left a comment

nice!

@reintroducing

This comment has been minimized.

Copy link
Contributor

reintroducing commented Dec 2, 2019

@jtomschroeder the watch task was actually what was stopping me from moving to gulp 4 as in my branch for that work I could not, for the life of me, get watch to work correctly as it did in gulp 3.x. I wonder if this would also help fix that issue...

@reintroducing reintroducing merged commit 572496d into master Dec 2, 2019
@reintroducing reintroducing deleted the gulp-watch branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.