Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: http-proxy-middleware support for all options #39

Merged
merged 1 commit into from Mar 4, 2020

Conversation

@sethomas
Copy link
Contributor

sethomas commented Mar 3, 2020

Description

In case each item in settingsConfig.webpack.client.development.proxy is a full object with options

otherwise, it will work the same with the shorthand:
https://github.com/chimurai/http-proxy-middleware#createproxymiddlewareuri--config

This change would promote the alignment of how devServer.proxy consumes the object

@sethomas sethomas requested a review from spothero/frontend as a code owner Mar 3, 2020
@sethomas sethomas merged commit 8dbe908 into master Mar 4, 2020
@sethomas sethomas deleted the http-proxy-middleware branch Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.