Added util factory class to remove duplicated code #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dargmuesli
reviewed
Nov 28, 2023
| } | ||
| } | ||
| return item; | ||
| return PlaylistItemFactory.createPlaylistItem(trackObj); |
There was a problem hiding this comment.
The indentation looks a bit off to me. The return statement should only be indented using two spaces instead of four as defined in the .editorconfig file in the repository's root.
There was a problem hiding this comment.
Yes, you're right! Thanks
| public class PlaylistItemFactory { | ||
| public static IPlaylistItem createPlaylistItem(JsonObject trackObj) { | ||
| IPlaylistItem item = null; | ||
| if (trackObj.has("type") && !trackObj.get("type").isJsonNull()) { |
There was a problem hiding this comment.
Let's keep the hasAndNotNull if we're at it trying to reduce duplicated code, no?
There was a problem hiding this comment.
Sorry for the delay
Yes, you're right. I fixed this to reuse this function
…e number of deeply nested if-then statements
aSTRonuun
force-pushed
the
refact/use-factory-class-to-remove-duplate-code
branch
from
1bd3b3d to
56c286d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone, I'm submitting this refactor to learn how to contribute to open source projects at the same time as I study "code smells" and I analyzed this at first and found this improvement
This rule recommends avoiding code that contains deeply nested if-then statements to improve code readability.