From d3d7524724ae9bff393fb958f9b9e79d4f8beb42 Mon Sep 17 00:00:00 2001 From: Nick Date: Mon, 20 Nov 2017 11:11:40 -0500 Subject: [PATCH] Fix log messages re: deployment group timeouts (#1191) --- .../java/com/spotify/helios/master/ZooKeeperMasterModel.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/helios-services/src/main/java/com/spotify/helios/master/ZooKeeperMasterModel.java b/helios-services/src/main/java/com/spotify/helios/master/ZooKeeperMasterModel.java index 15cd2729f..cbf61c4da 100644 --- a/helios-services/src/main/java/com/spotify/helios/master/ZooKeeperMasterModel.java +++ b/helios-services/src/main/java/com/spotify/helios/master/ZooKeeperMasterModel.java @@ -972,14 +972,14 @@ private boolean isRolloutTimedOut(final ZooKeeperClient client, } catch (KeeperException e) { // statusPath doesn't exist or some other ZK issue. probably this deployment group // was removed. - log.warn("error determining deployment group modification time: {}", groupName, e); + log.warn("error determining deployment group modification time: name={}", groupName, e); return false; } if (secondsSinceDeploy > groupTimeoutSetting) { log.info("rolling-update on deployment-group name={} has timed out after " + "{} seconds (rolloutOptions.timeout={})", - secondsSinceDeploy, groupTimeoutSetting); + groupName, secondsSinceDeploy, groupTimeoutSetting); return true; } return false;