This repository has been archived by the owner on Sep 29, 2021. It is now read-only.
Support all host selector operators in host cmd #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidxia
force-pushed
the
dxia/selectors
branch
2 times, most recently
from
cb78a6c
to
f74e84f
Compare
Current coverage is 49.66% (diff: 66.66%)@@ master #955 diff @@
==========================================
Files 272 272
Lines 12855 12847 -8
Methods 0 0
Messages 0 0
Branches 1663 1663
==========================================
+ Hits 6374 6380 +6
+ Misses 5994 5985 -9
+ Partials 487 482 -5
|
|
@spotify/helios-team |
| assertThat(nonHosts2, not(containsStrings(ImmutableSet.of(testHost1, testHost2)))); | ||
| } | ||
|
|
||
| private CustomTypeSafeMatcher<String> containsStrings(final Set<String> substrings) { |
There was a problem hiding this comment.
i think this could also be something like allOf(containsString(".."), ..) if you knew the set of strings at build-time
|
👍 it would be really sweet if we could do this filtering server-side (we have a need for something like this in our new project) |
We previously only supported the "=" host selector operator in `helios hosts --labels`. This change supports using "!=", "in", and "notin" operators.
|
@mattnworb Agreed. Lots of CLI logic could be moved server-side to simplify the client and reduce wasted bytes sent over the network. We can merge this first and then try that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously only supported the "=" host selector operator in
helios hosts --labels. This change supports using "!=", "in",and "notin" operators.