From 06ac494bcc5172c7f4ebddcdf7d3d3e64bfd2193 Mon Sep 17 00:00:00 2001 From: Erik Bernhardsson Date: Mon, 26 Jan 2015 15:51:02 -0500 Subject: [PATCH] pep8 fixes --- luigi/parameter.py | 6 ++++-- luigi/rpc.py | 3 +-- test/parameter_test.py | 2 +- tox.ini | 2 +- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/luigi/parameter.py b/luigi/parameter.py index 2edacfd677..1265a53d87 100644 --- a/luigi/parameter.py +++ b/luigi/parameter.py @@ -323,17 +323,19 @@ def add_to_cmdline_parser(self, parser, param_name, task_name, optparse=False, g dest=dest) def parse_from_args(self, param_name, task_name, args, params): + # Note: modifies arguments dest = self.parser_dest(param_name, task_name, glob=False) if dest is not None: value = getattr(args, dest, None) - params[param_name] = self.parse_from_input(param_name, value) # Note: modifies arguments + params[param_name] = self.parse_from_input(param_name, value) def set_global_from_args(self, param_name, task_name, args): + # Note: side effects dest = self.parser_dest(param_name, task_name, glob=True) if dest is not None: value = getattr(args, dest, None) if value is not None: - self.set_global(self.parse_from_input(param_name, value)) # Note: side effects + self.set_global(self.parse_from_input(param_name, value)) class DateHourParameter(Parameter): diff --git a/luigi/rpc.py b/luigi/rpc.py index 272a5ecf7b..4acaa093ac 100644 --- a/luigi/rpc.py +++ b/luigi/rpc.py @@ -116,8 +116,7 @@ def get_work(self, worker, host=None): '/api/get_work', {'worker': worker, 'host': host}, log_exceptions=False, - attempts=1 - ) + attempts=1) def graph(self): return self._request('/api/graph', {}) diff --git a/test/parameter_test.py b/test/parameter_test.py index 0b85311544..1f3d42a40f 100644 --- a/test/parameter_test.py +++ b/test/parameter_test.py @@ -120,7 +120,7 @@ class Banana(luigi.Task): def requires(self): if self.style is None: - return BananaDep() # will fail + return BananaDep() # will fail elif self.style == 'x-arg': return BananaDep(self.x) elif self.style == 'y-kwarg': diff --git a/tox.ini b/tox.ini index de3c4da186..957a519311 100644 --- a/tox.ini +++ b/tox.ini @@ -24,7 +24,7 @@ commands = [testenv:pep8] deps = pep8 -commands = /usr/bin/env bash -c 'pep8 --ignore E501 luigi test examples bin || true' +commands = pep8 --ignore E501 luigi test examples bin [testenv:autopep8] deps = autopep8