Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Configure logging via TOML config #2483
Motivation and Context
Q. Why do you use same file for Luigi's config and logging config?
Q. Why do you do this? We already have support for
Q. Why do you change
Q. Why do you change code structure?
Have you tested this? If so, how?
Thank you for best pipeline library. And best music streaming service too. All this things is amazing!
left a comment
So cool to see that we're getting somewhere with improving the logging experience in luigi!
I just added a lot of comments on the code so that the code for this important core part of luigi keeps a high standard. I hope you can find time to address this stuff. I'm happy to merge (without more approval from me) once the issues are addressed.
I got feedback and have fixed example based on this:
I think, it will be better change
So. now it is ready, I hope :)