Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give a few default values to opts when setting up logging #2612

merged 1 commit into from Dec 19, 2018


Copy link

honnix commented Dec 19, 2018


Give default values to opts used for setting up logging.

Motivation and Context

To make usage of setup a bit simpler.

Have you tested this? If so, how?

@honnix honnix requested review from dlstadther, Tarrasch and ulzha as code owners Dec 19, 2018
@honnix honnix merged commit e17a224 into master Dec 19, 2018
4 checks passed
4 checks passed
codecov/changes No unexpected coverage changes found.
codecov/patch 100% of diff hit (target 77.36%)
codecov/project/core 93.11% (target 92%)
continuous-integration/travis-ci/pr The Travis CI build passed
@honnix honnix deleted the default-opts branch Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.