Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration documentation: remove deprecated/wrong [core]max_reschedules entry #2692

Merged
merged 1 commit into from Apr 13, 2019

Conversation

@soxofaan
Copy link
Contributor

soxofaan commented Apr 12, 2019

The configration doc contains entry on [core]max_reschedules,
which is not only deprecated (in favor of [worker]max_reschedules)
but also wrong: the correct (but deprecated) config key is
[core]worker-max-reschedules.
Better get rid of this all together and just keep [worker]max_reschedules

…dules entry

The configration doc contains entry on `[core]max_reschedules`,
which is not only deprecated (in favor of `[worker]max_reschedules`)
but also wrong: the correct (but deprecated) config key is
`[core]worker-max-reschedules`.
Better get rid of this all together and just keep `[worker]max_reschedules`
@soxofaan soxofaan requested review from dlstadther, honnix and Tarrasch as code owners Apr 12, 2019
Copy link
Collaborator

dlstadther left a comment

Thanks so much for improving documentation!

@dlstadther dlstadther merged commit 329c136 into spotify:master Apr 13, 2019
4 checks passed
4 checks passed
codecov/changes No unexpected coverage changes found.
Details
codecov/patch Coverage not affected when comparing c0316de...43e9482
Details
codecov/project/core 93.02% (target 92%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.