New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1088 set schema on the TypedWrite #1089

Merged
merged 3 commits into from Mar 27, 2018

Conversation

Projects
None yet
4 participants
@andrewsmartin
Contributor

andrewsmartin commented Mar 27, 2018

No description provided.

@@ -231,7 +231,7 @@ object AvroType {
*
* This decouples generated fields and methods from macro expansion to keep core macro free.
*/
class AvroType[T: TypeTag] {
class AvroType[T: TypeTag] extends Serializable {

This comment has been minimized.

@nevillelyh

nevillelyh Mar 27, 2018

Member

Where is AvroType pulled into a lambda?

@nevillelyh

nevillelyh Mar 27, 2018

Member

Where is AvroType pulled into a lambda?

This comment has been minimized.

@andrewsmartin

andrewsmartin Mar 27, 2018

Contributor

In the function that converts typed objects to generic record. https://github.com/spotify/scio/pull/1089/files#diff-417755bd55a6dbb7a50a9f58d6a7af4bL973

@andrewsmartin
Show outdated Hide outdated scio-test/src/it/scala/com/spotify/scio/avro/TypedAvroIT.scala
Show outdated Hide outdated scio-test/src/it/scala/com/spotify/scio/avro/TypedAvroIT.scala
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Mar 27, 2018

Codecov Report

Merging #1089 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1089      +/-   ##
=========================================
+ Coverage   82.22%   82.5%   +0.28%     
=========================================
  Files         116     116              
  Lines        3943    3944       +1     
  Branches      443     426      -17     
=========================================
+ Hits         3242    3254      +12     
+ Misses        701     690      -11
Impacted Files Coverage Δ
...n/scala/com/spotify/scio/avro/types/AvroType.scala 88.88% <ø> (+33.33%) ⬆️
...in/scala/com/spotify/scio/values/SCollection.scala 78.62% <100%> (+2.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f73092...262b462. Read the comment docs.

codecov-io commented Mar 27, 2018

Codecov Report

Merging #1089 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1089      +/-   ##
=========================================
+ Coverage   82.22%   82.5%   +0.28%     
=========================================
  Files         116     116              
  Lines        3943    3944       +1     
  Branches      443     426      -17     
=========================================
+ Hits         3242    3254      +12     
+ Misses        701     690      -11
Impacted Files Coverage Δ
...n/scala/com/spotify/scio/avro/types/AvroType.scala 88.88% <ø> (+33.33%) ⬆️
...in/scala/com/spotify/scio/values/SCollection.scala 78.62% <100%> (+2.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f73092...262b462. Read the comment docs.

@andrewsmartin andrewsmartin merged commit 53b2ee3 into master Mar 27, 2018

2 checks passed

ci/circleci: build_211 Your tests passed on CircleCI!
Details
ci/circleci: build_212 Your tests passed on CircleCI!
Details

@andrewsmartin andrewsmartin deleted the andrew/typed-avro branch Mar 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment