Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elasticsearch 6 #1572

Merged
merged 1 commit into from Dec 17, 2018

Conversation

@regadas
Copy link
Contributor

commented Dec 6, 2018

No description provided.

@regadas regadas force-pushed the regadas:feature/elasticsearch6 branch from a9c536c to 14ac2cd Dec 6, 2018

@regadas regadas added the WIP label Dec 6, 2018

@regadas regadas force-pushed the regadas:feature/elasticsearch6 branch 2 times, most recently from f341f61 to 0511bf9 Dec 6, 2018

@regadas regadas force-pushed the regadas:feature/elasticsearch6 branch from 0511bf9 to baffb89 Dec 6, 2018

@regadas regadas removed the WIP label Dec 6, 2018

@jto jto referenced this pull request Dec 12, 2018

Closed

Update elasticsearch to 6.5.3 #1576

try {
final BulkRequest bulkRequest = new BulkRequest().add(chunk.toArray(
new DocWriteRequest[0]));
final BulkResponse bulkItemResponse = clientSupplier.get().bulk(bulkRequest).get();

This comment has been minimized.

Copy link
@ClaireMcGinty

ClaireMcGinty Dec 13, 2018

Contributor

depending on how this worker is threaded, would it make more sense to use java Future callbacks instead of blocking for every request?

This comment has been minimized.

Copy link
@regadas

regadas Dec 17, 2018

Author Contributor

Threaded model here is managed by beam and in this case since it's a sink it's kinda "ok" to block, since each list of bulk requests happen in a different thread and we don't have a proper rate-limit/retry police in place.

return;
}

final Stream<DocWriteRequest> docWriteRequests =

This comment has been minimized.

Copy link
@ClaireMcGinty

ClaireMcGinty Dec 13, 2018

Contributor

At any point do we want to support IndexRequests/DeleteRequests?

This comment has been minimized.

Copy link
@regadas

regadas Dec 17, 2018

Author Contributor

That's supported by DocWriteRequest

@regadas regadas merged commit aeb223a into spotify:master Dec 17, 2018

3 checks passed

ci/circleci: build_211 Your tests passed on CircleCI!
Details
ci/circleci: build_212 Your tests passed on CircleCI!
Details
ci/circleci: checks Your tests passed on CircleCI!
Details

@regadas regadas deleted the regadas:feature/elasticsearch6 branch Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.