Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Numeric type support in scio-bigquery #1599

Merged
merged 2 commits into from Dec 26, 2018

Conversation

@regadas
Copy link
Contributor

commented Dec 22, 2018

This is a follow up to the PR #1584 made by @lazyval.

Store bigdecimal as NUMERIC in BQ
Do not enforce math context

not sure if math context round-trip should be guaranteed

Add a missing copyright banner

@regadas regadas force-pushed the regadas:bigdecimals-for-big-query branch 2 times, most recently from ffb28b6 to 202b8bb Dec 22, 2018

@codecov

This comment has been minimized.

Copy link

commented Dec 22, 2018

Codecov Report

Merging #1599 into master will decrease coverage by 0.8%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1599      +/-   ##
==========================================
- Coverage   69.78%   68.97%   -0.81%     
==========================================
  Files         174      174              
  Lines        5249     5261      +12     
  Branches      381      370      -11     
==========================================
- Hits         3663     3629      -34     
- Misses       1586     1632      +46
Impacted Files Coverage Δ
...potify/scio/bigquery/types/ConverterProvider.scala 100% <ø> (ø) ⬆️
...m/spotify/scio/bigquery/types/SchemaProvider.scala 95.23% <100%> (+0.11%) ⬆️
...main/scala/com/spotify/scio/bigquery/package.scala 57.97% <88.88%> (+4.63%) ⬆️
...scala/com/spotify/scio/bigquery/client/Cache.scala 0% <0%> (-55.56%) ⬇️
.../spotify/scio/bigquery/client/BigQueryConfig.scala 0% <0%> (-50%) ⬇️
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 0% <0%> (-46.16%) ⬇️
...com/spotify/scio/bigquery/types/BigQueryType.scala 37.5% <0%> (-25%) ⬇️
...n/scala/com/spotify/scio/bigquery/BigQueryIO.scala 25% <0%> (-3.85%) ⬇️
...la/com/spotify/scio/bigquery/client/BigQuery.scala 27.02% <0%> (-2.71%) ⬇️
...com/spotify/scio/bigquery/types/TypeProvider.scala 76.59% <0%> (-2.13%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e330c9...6779799. Read the comment docs.

@regadas regadas force-pushed the regadas:bigdecimals-for-big-query branch from 202b8bb to 6779799 Dec 22, 2018

@regadas regadas merged commit cbe68bc into spotify:master Dec 26, 2018

3 checks passed

ci/circleci: build_211 Your tests passed on CircleCI!
Details
ci/circleci: build_212 Your tests passed on CircleCI!
Details
ci/circleci: checks Your tests passed on CircleCI!
Details

@regadas regadas deleted the regadas:bigdecimals-for-big-query branch Dec 26, 2018

regadas added a commit that referenced this pull request Dec 26, 2018

Add Numeric type support in scio-bigquery (#1599)
* Store bigdecimal as NUMERIC in BQ

Do not enforce math context

not sure if math context round-trip should be guaranteed

Add a missing copyright banner

* Apply same MathContext settings and use Property-based testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.