Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit reset position on SeekableInput #1747

Merged
merged 4 commits into from Mar 12, 2019
Merged

Explicit reset position on SeekableInput #1747

merged 4 commits into from Mar 12, 2019

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Mar 12, 2019

No description provided.

clairemcginty
clairemcginty approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@clairemcginty clairemcginty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! there's a scalastyle issue with result.value.hasNext should be true tho. could you just use assert(result.value.hasNext) ?

@regadas
Copy link
Contributor Author

regadas commented Mar 12, 2019

@clairemcginty I can, but most of our tests use the Matchers dsl

@regadas regadas merged commit 392f334 into spotify:master Mar 12, 2019
@regadas regadas deleted the chore/followup-1727 branch March 12, 2019 19:06
@regadas regadas mentioned this pull request Mar 13, 2019
Closed
regadas added a commit that referenced this pull request Mar 13, 2019
@regadas
Explicit reset position on SeekableInput (#1747)
9bc0be4
andrisnoko pushed a commit that referenced this pull request Mar 15, 2019
@regadas @andrisnoko
Explicit reset position on SeekableInput (#1747)
ce1480f
andrisnoko pushed a commit that referenced this pull request Mar 15, 2019
@regadas @andrisnoko
Explicit reset position on SeekableInput (#1747)
ca27f5d
andrisnoko pushed a commit that referenced this pull request Mar 15, 2019
@regadas @andrisnoko
Explicit reset position on SeekableInput (#1747)
190a2cd
andrisnoko pushed a commit that referenced this pull request Mar 15, 2019
@regadas @andrisnoko
Explicit reset position on SeekableInput (#1747)
a16fc53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clairemcginty clairemcginty clairemcginty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@regadas @clairemcginty