Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BigQuery client project consistently #2995

Merged
merged 5 commits into from May 21, 2020

Conversation

regadas
Copy link
Contributor

@regadas regadas commented May 20, 2020

Fixes #2994
Fixes #2928, It will allow compilation without projectId in the spec. However, it must be defined either through -Dbigquery.project, env or .config/gcloud

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #2995 into master will decrease coverage by 2.60%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2995      +/-   ##
==========================================
- Coverage   72.67%   70.06%   -2.61%     
==========================================
  Files         225      225              
  Lines        7490     7489       -1     
  Branches      322      333      +11     
==========================================
- Hits         5443     5247     -196     
- Misses       2047     2242     +195     
Impacted Files Coverage Δ
...la/com/spotify/scio/bigquery/client/TableOps.scala 0.00% <0.00%> (-25.75%) ⬇️
...scala/com/spotify/scio/bigquery/client/Cache.scala 0.00% <0.00%> (-74.08%) ⬇️
.../spotify/scio/bigquery/client/BigQueryConfig.scala 0.00% <0.00%> (-70.59%) ⬇️
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 0.00% <0.00%> (-52.50%) ⬇️
...scala/com/spotify/scio/bigquery/BigQueryUtil.scala 50.00% <0.00%> (-50.00%) ⬇️
...otify/scio/bigquery/syntax/ScioContextSyntax.scala 19.35% <0.00%> (-41.94%) ⬇️
...la/com/spotify/scio/bigquery/client/QueryOps.scala 0.73% <0.00%> (-39.71%) ⬇️
.../scala/com/spotify/scio/bigquery/StorageUtil.scala 0.00% <0.00%> (-36.85%) ⬇️
...com/spotify/scio/bigquery/types/BigQueryType.scala 58.33% <0.00%> (-29.17%) ⬇️
...com/spotify/scio/bigquery/types/TypeProvider.scala 52.11% <0.00%> (-22.54%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbf3267...d4e4d34. Read the comment docs.

…yPartitionUtil.scala

Co-authored-by: Neville Li <neville.lyh@gmail.com>
@nevillelyh nevillelyh merged commit 766c76d into spotify:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants