Skip to content
Browse files

Merge pull request #58 from kou/test-unit-use-const-defined

Use const_defined? for checking a constant is defined
  • Loading branch information...
2 parents eac828b + e7a0ff8 commit 31f0dd73b497f2e8a9a8845a11c07902316e1905 @nicksieger nicksieger committed
Showing with 2 additions and 2 deletions.
  1. +2 −2 lib/ci/reporter/test_unit.rb
View
4 lib/ci/reporter/test_unit.rb
@@ -13,8 +13,8 @@ module Reporter
class Failure
def self.new(fault)
return TestUnitFailure.new(fault) if fault.kind_of?(Test::Unit::Failure)
- return TestUnitSkipped.new(fault) if !(Test::Unit.constants & [:Omission, "Omission"]).empty? && (fault.kind_of?(Test::Unit::Omission) || fault.kind_of?(Test::Unit::Pending))
- return TestUnitNotification.new(fault) if !(Test::Unit.constants & [:Notification, "Notification"]).empty? && fault.kind_of?(Test::Unit::Notification)
+ return TestUnitSkipped.new(fault) if Test::Unit.const_defined?(:Omission) && (fault.kind_of?(Test::Unit::Omission) || fault.kind_of?(Test::Unit::Pending))
+ return TestUnitNotification.new(fault) if Test::Unit.const_defined?(:Notification) && fault.kind_of?(Test::Unit::Notification)
TestUnitError.new(fault)
end
end

0 comments on commit 31f0dd7

Please sign in to comment.
Something went wrong with that request. Please try again.