Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

= servlet: add termination awaiting to Initializer::contextDestroyed #787

Merged
merged 1 commit into from Mar 5, 2014

Conversation

TulioDomingos
Copy link
Contributor

Release memory by making sure all threads are stopped before app undeployment takes place.

More info at:
https://groups.google.com/forum/#!topic/spray-user/4wwQbHFXkxk
https://groups.google.com/forum/#!topic/akka-user/Lp2hn4FfhU8

@sirthias
Copy link
Member

sirthias commented Mar 3, 2014

Tulio, great, thanks for this fix!

Two things we'd need before we can merge this:

  1. Can you accept the Typesafe CLA?
  2. Please rephrase the commit message to:
= servlet: add termination awaiting to `Initializer::contextDestroyed`

(in accordance with our commit message policy)

@TulioDomingos
Copy link
Contributor Author

Done!

@jrudolph
Copy link
Member

jrudolph commented Mar 4, 2014

Have you checked that it works, @TulioDomingos ? Otherwise, it looks simple enough to me. 👍

@sirthias
Copy link
Member

sirthias commented Mar 4, 2014

Thanks for accepting the CLA!
Could you also update the commit message?

@TulioDomingos
Copy link
Contributor Author

@jrudolph Yep, it works! The following errors don't show up in Tomcat anymore

SEVERE: The web application [/spray-template_2.10-0.1] appears to have started a thread named [example-scheduler-1] but has failed to stop it. This is very likely to create a memory leak.

SEVERE: The web application [/spray-template_2.10-0.1] appears to have started a thread named [example-akka.actor.default-dispatcher-2] but has failed to stop it. This is very likely to create a memory leak.

jrudolph added a commit that referenced this pull request Mar 5, 2014
= servlet: add termination awaiting to `Initializer::contextDestroyed`
@jrudolph jrudolph merged commit 661281c into spray:master Mar 5, 2014
@jrudolph
Copy link
Member

jrudolph commented Mar 5, 2014

Excellent. Thanks again.

@TulioDomingos
Copy link
Contributor Author

You're welcome. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants