From d2a2229313b9f0e05f5fefb0e85c6313a4e5966c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=80=9Emarianfoo=E2=80=9C?= <13335743+marianfoo@users.noreply.github.com> Date: Wed, 3 Jul 2024 15:44:55 +0200 Subject: [PATCH 1/2] docs: document the new ui5 tooling task --- docs/pages/GettingStarted.md | 29 ++++++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/docs/pages/GettingStarted.md b/docs/pages/GettingStarted.md index 1ddcdb65..a7fbb748 100644 --- a/docs/pages/GettingStarted.md +++ b/docs/pages/GettingStarted.md @@ -399,4 +399,31 @@ builder: archiveName: uimodule includeDependencies: - ui5-cc-spreadsheetimporter -``` \ No newline at end of file +``` + +#### Update `"sap.cloud".service` in Spreadsheet Importer manifest.json + +When you are using the decentral deployment and try to deploy, it is possible that the deployment fails with the following error: + +`"Service name 'spreadsheetimporter_v1_1_1' and public setting 'true' in embedded manifest.json have to be equal to service name 'xxxxxxx' and public setting 'true' of root manifest.json"` + +You could manually update the `service` name in the `manifest.json` of the Spreadsheet Importer to match the service name in the `manifest.json` of your app. +To automate this, you can use the custom task for the UI5 Tooling [`ui5-task-btp-manifest`](https://github.com/spreadsheetimporter/ui5-task-btp-manifest) + +##### Install the task + +```bash +npm install --save-dev ui5-task-btp-manifest +``` + +##### Add the task to your `ui5.yaml` + +```yml +builder: + customTasks: + - name: ui5-task-btp-manifest + afterTask: replaceVersion +``` + +This will update the manifest file of the Spreadsheet Importer with the service name of the app like to this path: +`dist/thirdparty/customcontrol/spreadsheetimporter/v1_1_1/manifest.json` \ No newline at end of file From f4d9c06f9be9dfc3f53720c0a76e62e1393ab368 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=80=9Emarianfoo=E2=80=9C?= <13335743+marianfoo@users.noreply.github.com> Date: Wed, 10 Jul 2024 10:24:55 +0200 Subject: [PATCH 2/2] docs: update --- docs/pages/GettingStarted.md | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/docs/pages/GettingStarted.md b/docs/pages/GettingStarted.md index a7fbb748..e6c372b2 100644 --- a/docs/pages/GettingStarted.md +++ b/docs/pages/GettingStarted.md @@ -403,20 +403,25 @@ builder: #### Update `"sap.cloud".service` in Spreadsheet Importer manifest.json -When you are using the decentral deployment and try to deploy, it is possible that the deployment fails with the following error: +When you are using the decentral deployment and try to deploy, it is possible that the deployment fails with the following error: `"Service name 'spreadsheetimporter_v1_1_1' and public setting 'true' in embedded manifest.json have to be equal to service name 'xxxxxxx' and public setting 'true' of root manifest.json"` -You could manually update the `service` name in the `manifest.json` of the Spreadsheet Importer to match the service name in the `manifest.json` of your app. -To automate this, you can use the custom task for the UI5 Tooling [`ui5-task-btp-manifest`](https://github.com/spreadsheetimporter/ui5-task-btp-manifest) +As of now, according to SAP, this will not be changed. -##### Install the task +##### Workaround 1 + +You can manually update the `service` name in the `manifest.json` of the Spreadsheet Importer to match the service name in the `manifest.json` of your app. + +I tried to automate this and you can use the custom task for the UI5 Tooling [`ui5-task-btp-manifest`](https://github.com/spreadsheetimporter/ui5-task-btp-manifest) + +###### Install the task ```bash npm install --save-dev ui5-task-btp-manifest ``` -##### Add the task to your `ui5.yaml` +###### Add the task to your `ui5.yaml` ```yml builder: @@ -426,4 +431,11 @@ builder: ``` This will update the manifest file of the Spreadsheet Importer with the service name of the app like to this path: -`dist/thirdparty/customcontrol/spreadsheetimporter/v1_1_1/manifest.json` \ No newline at end of file +`dist/thirdparty/customcontrol/spreadsheetimporter/v1_1_1/manifest.json` + +##### Workaround 2 + +According to the [comment from user TravelTechCode](https://github.com/spreadsheetimporter/ui5-cc-spreadsheetimporter/issues/582#issuecomment-2210564980) you can try to deploy the app without the packaged component first: + + +> Though one hack i found is that ,if i deploy my app first without the ui5 spreadsheet component and then add and deploy the ui5 spreadsheet component in the second deployment, then it's not causing any deployment error and can be access in the content explorer too. \ No newline at end of file