Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix for default_weight of 0 error and added support for a max package weight #48

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

FineLineAutomation commented Jan 7, 2013

A default weight of zero doesn't throw a divide by zero error anymore. Added a test condition for it.

The max weight per package is useful if you want to

a) limit package weights so they don't go above carrier limits like UPS's 150lb limit.
b) have a company rule that splits boxes after a certain weight.

It is implemented to respect the countries max weight if that happens to be lower.

FineLineAutomation added some commits Dec 22, 2012

@FineLineAutomation FineLineAutomation Add configuration page for active_shipping settings
The page shows up in the configuration tab and allows you to set all of the settings available in the extension.

Signed-off-by: Nathan Lowrie <nate@finelineautomation.com>
ff9f772
@FineLineAutomation FineLineAutomation Fix: Allow a default_weight of zero
A default weight of zero doesn't throw a divide by zero error anymore.  Added a test condition for it.

Signed-off-by: Nathan Lowrie <nate@finelineautomation.com>
4b5ac55
@FineLineAutomation FineLineAutomation Added the ability to define a max weight per package.
The max weight per package is useful if you want to

a) limit package weights so they don't go above carrier limits like UPS's 150lb limit.
b) have a company rule that splits boxes after a certain weight.

It is implemented to respect the countries max weight if that happens to be lower.

Signed-off-by: Nathan Lowrie <nate@finelineautomation.com>
882ec0c
@FineLineAutomation FineLineAutomation Merge branch 'master' of https://github.com/spree/spree_active_shipping
Signed-off-by: Nathan Lowrie <nate@finelineautomation.com>

Conflicts:
	app/views/spree/admin/active_shipping_settings/edit.html.erb
	app/views/spree/admin/active_shipping_settings/show.html.erb
d2e264b

@radar radar closed this in 5d82b77 Jan 7, 2013

Contributor

radar commented Jan 7, 2013

Added to 1-3-stable and master. Thanks!

@radar radar added a commit that referenced this pull request Jan 7, 2013

@FineLineAutomation @radar FineLineAutomation + radar Added the ability to define a max weight per package.
The max weight per package is useful if you want to

a) limit package weights so they don't go above carrier limits like UPS's 150lb limit.
b) have a company rule that splits boxes after a certain weight.

It is implemented to respect the countries max weight if that happens to be lower.

Signed-off-by: Nathan Lowrie <nate@finelineautomation.com>

Fixes #48
01b98fd
Contributor

FineLineAutomation commented Jan 8, 2013

I should have product packages here in a few days.

Sent from my iPad

On Jan 7, 2013, at 18:03, Ryan Bigg notifications@github.com wrote:

Added to 1-3-stable and master. Thanks!


Reply to this email directly or view it on GitHub.

Contributor

FineLineAutomation commented Jan 8, 2013

Ryan,

I think you missed commit 4b5acc5, which fixes a divide by zero error when the default_weight is 0 and a item_weight is 0 or negative.

Regards,

Nate

Contributor

radar commented Jan 8, 2013

Right you are, Nate. I've added that commit now to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment