From 78dc93b19c8da4a7bdc6e20aa61bf5e804ee94cc Mon Sep 17 00:00:00 2001 From: Krzysztof Rybka Date: Sat, 6 Aug 2016 12:26:21 +0200 Subject: [PATCH] don't use hardcoded ids in specs --- spec/controllers/spree/admin/relations_controller_spec.rb | 2 +- spec/controllers/spree/api/relations_controller_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/controllers/spree/admin/relations_controller_spec.rb b/spec/controllers/spree/admin/relations_controller_spec.rb index fe087895..137a3f17 100644 --- a/spec/controllers/spree/admin/relations_controller_spec.rb +++ b/spec/controllers/spree/admin/relations_controller_spec.rb @@ -55,7 +55,7 @@ context '#update' do it 'redirects to product/related url' do - spree_put :update, product_id: product.id, id: 1, relation: { discount_amount: 2.0 } + spree_put :update, product_id: product.id, id: relation.id, relation: { discount_amount: 2.0 } expect(response).to redirect_to(spree.admin_product_path(relation.relatable) + '/related') end end diff --git a/spec/controllers/spree/api/relations_controller_spec.rb b/spec/controllers/spree/api/relations_controller_spec.rb index efa5d56c..a81fd50a 100644 --- a/spec/controllers/spree/api/relations_controller_spec.rb +++ b/spec/controllers/spree/api/relations_controller_spec.rb @@ -59,7 +59,7 @@ context '#destroy with' do it 'records successfully' do expect { - spree_delete :destroy, id: 1, product_id: product.id, format: :json, token: user.spree_api_key + spree_delete :destroy, id: relation.id, product_id: product.id, format: :json, token: user.spree_api_key }.to change(Spree::Relation, :count).by(-1) end end