Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Hide "Sign In Through One Of These Services:" text when no services are available and improve Facebook and Twitter login #25

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

phillcampbell commented Apr 4, 2012

When you first install spree_social or if you disable all the providers the text "Sign In Through One Of These Services:" and Add Another Service To Sign In With: is visible on the login, sign up and account pages.

Obviously this looks messy and this commit will remove the text when not required.

Owner

JDutil commented Apr 4, 2012

Good idea, but could you make activeAuthenticationMethods? snakecase rather than camelcase?

active_authentication_methods?
Contributor

phillcampbell commented Apr 4, 2012

Ok, I have changed that. I am quite new to Rails and not sure of all the conventions yet.

Contributor

phillcampbell commented Apr 4, 2012

I have also updated my code to improve Facebook and Twitter logins.

Email address is retrieved from the Facebook callback so no further steps are required to register.

Twitter does not provide an email so we still redirect to the signup page, however, the password fields are hidden and the text is changed to make it clear that you are confirming your email. Previously it appeared as if the social login had failed.

Apologies for doing this is in the same pull request, I don't know how to separate the two into different pulls.

Contributor

LBRapid commented Apr 5, 2012

Looks solid to me. Bringing these commits over now. Thanks!

@LBRapid LBRapid closed this Apr 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment