Skip to content

Commit

Permalink
Each component will now have its own Gemfile.
Browse files Browse the repository at this point in the history
This is to address the problem in #1292.
  • Loading branch information
radar committed Mar 19, 2012
1 parent 0740d12 commit 134f2f3
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 1 deletion.
1 change: 0 additions & 1 deletion .gitignore
Expand Up @@ -23,7 +23,6 @@ db/*.sqlite3*
db/schema.rb
doc/**/*
Gemfile.lock
*/Gemfile
*/Gemfile.lock
lib/products_index_profiler.rb
log/*.log
Expand Down
3 changes: 3 additions & 0 deletions api/Gemfile
@@ -0,0 +1,3 @@
eval(File.read(File.dirname(__FILE__) + '/../common_spree_dependencies.rb'))

gemspec
3 changes: 3 additions & 0 deletions auth/Gemfile
@@ -0,0 +1,3 @@
eval(File.read(File.dirname(__FILE__) + '/../common_spree_dependencies.rb'))

gemspec
3 changes: 3 additions & 0 deletions core/Gemfile
@@ -0,0 +1,3 @@
eval(File.read(File.dirname(__FILE__) + '/../common_spree_dependencies.rb'))

gemspec
3 changes: 3 additions & 0 deletions dash/Gemfile
@@ -0,0 +1,3 @@
eval(File.read(File.dirname(__FILE__) + '/../common_spree_dependencies.rb'))

gemspec
3 changes: 3 additions & 0 deletions promo/Gemfile
@@ -0,0 +1,3 @@
eval(File.read(File.dirname(__FILE__) + '/../common_spree_dependencies.rb'))

gemspec

3 comments on commit 134f2f3

@schof
Copy link
Contributor

@schof schof commented on 134f2f3 Mar 20, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radar major objection to this. lets talk about this later today

@radar
Copy link
Contributor Author

@radar radar commented on 134f2f3 Mar 20, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's important as it allows all components to be tested in isolation. If people are wanting to only use core (as shown in #1292) then we should ensure that they can do that.

@citrus
Copy link
Contributor

@citrus citrus commented on 134f2f3 Mar 20, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schof - @radar is right. We need to test each part of spree in isolation to ensure that the modularity of spree stays in tact. v1.0.2 and v1.0.3 both made the core useless without spree_auth.

Please sign in to comment.