Shipping Methods should Disable, not Delete #1240

Closed
GeekOnCoffee opened this Issue Mar 7, 2012 · 1 comment

2 participants

@GeekOnCoffee

Currently Deleting a Shipping Method removes it from the table. This breaks orders that had this shipping method set, and may also break shipping categories, etc.

If you have a cart in progress, you loose the ability to move around the cart. I believe it also breaks the ability to see it in the admin.

I think the best solution to this is to set a "deleted_at" flag that disables it from being used. This will maintain the relationships and history.

@radar
Spree Commerce member

I agree. I've seen this error come up a couple of times myself.

@radar radar closed this in 25996a2 Jun 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment