Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Spree locale scope conflicts with existing app #1342

Closed
steveh opened this Issue Apr 2, 2012 · 4 comments

Comments

Projects
None yet
2 participants
Contributor

steveh commented Apr 2, 2012

My existing apps' config/locales/en.yml already defines many keys that conflict with Spree, e.g. "users".

Should Spree define its locale keys in its own scope? Is there a simple way to change this already that I've overlooked?

As an aside, when keys are duplicated, this breaks Spree::Admin::NavigationHelper#tab as I18n.t() returns a Hash which titleize() does not accept.

Member

radar commented Apr 2, 2012

Yes, Spree should define these in its own scopes.

Member

radar commented Apr 2, 2012

The problem with doing this is that it's not a trivial change. Would require us to look for all translations inside of Spree and fix them up. I can take a look at this tomorrow.

Contributor

steveh commented Apr 2, 2012

Yeah I can imagine this would be an enormous job; coordinating a breaking change amongst all translations. I was more hoping I had just overlooked something simple to do this for me, like a per-Engine i18n scope or something. For the time being I'll just change my own app scope instead.

Member

radar commented Apr 5, 2012

This is probably too big a change to slot into a point release. We should investigate it for 2.x.

@radar radar closed this Apr 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment