hidden submit tag needed? #1535

Closed
wandtasie opened this Issue May 14, 2012 · 6 comments

3 participants

@wandtasie

I found this submit tag:

<%= submit_tag nil, :id => 'post-final', :style => 'display:none;' %>

here: https://github.com/spree/spree/blob/master/core/app/views/spree/checkout/edit.html.erb#L16

Is this needed for something special or can we (I) delete this?

@BDQ
Spree Commerce member

I think it can be deleted, try dropping it and running the test suite to see if it passes.

@wandtasie

I'm sorry, no time at the moment, maybe I can do this tomorrow... Thanks!

@wandtasie

before

Finished in 2 minutes 31.43 seconds
729 examples, 0 failures, 25 pending

#1538

after

Finished in 2 minutes 30.38 seconds
729 examples, 0 failures, 25 pending

@schof
Spree Commerce member

Not only did we remove a useless button but we saved 0.05 seconds running the test suite :)

@schof
Spree Commerce member

@wandtasie thanks for the contribution - we're always looking for more help

@schof schof added a commit that closed this issue May 15, 2012
Matthias Wagner Removed useless hidden submit button
[Fixes #1535] [Fixes #1538]
0fafceb
@schof schof closed this in 0fafceb May 15, 2012
@tvdeyen tvdeyen pushed a commit to magiclabs/spree that referenced this issue Jun 1, 2012
Matthias Wagner Removed useless hidden submit button
[Fixes #1535] [Fixes #1538]
9de1d8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment