Spree::Calculator::SalesTax errors on 0.70 to 1.0 migration #1581

Closed
binaryphile opened this Issue May 22, 2012 · 4 comments

Comments

Projects
None yet
2 participants
Contributor

binaryphile commented May 22, 2012

If you have a sales tax entry in your database when migrating from 0.70 to 1.0, checkout throws an error saying it can't find that calculator.

That's because, according to the release notes, both the VAT calculator and SalesTax calculator have been replaced by the refactored DefaultTax calculator.

For me, it was necessary to issue the mysql command:

update spree_calculators set type='Spree::Calculator::DefaultTax' where type='Spree::Calculator::SalesTax'

I would imagine something similar would be necessary to replace the VAT tax calculator.

The release notes only go so far as to say (paraphrasing) "Taxes are broke after the upgrade." One could infer a "Tough cookies." after that. ;)

I'd suggest a) working this (or any other) solution into the upgrade doc or, even better, b) implementing a migration which handles this for the user.

Thanks!

Member

radar commented May 23, 2012

Could you please submit a patch to 1-0-stable that adds a migration that performs this task?

@radar radar closed this in 5e76b40 May 23, 2012

Member

radar commented May 23, 2012

Merged with @5e76b40. Thanks!

Member

radar commented May 23, 2012

And into 1-1-stable and master with @3ceb5c6 and @02e8f43 respectively.

Contributor

binaryphile commented May 23, 2012

Sweet!

mscottford pushed a commit to mscottford/spree that referenced this issue May 24, 2012

joahking pushed a commit to joahking/spree that referenced this issue May 25, 2012

tvdeyen pushed a commit to magiclabs/spree that referenced this issue Jun 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment