GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
In Variant before_save :touch_product:
It seems to me that we should touch product if variant is master. Any thought?
The master variant is only updated when a product is updated also, and so the product will be "touched" then. When updating a variant on its own, it doesn't touch the product and so this callback needs to be there.
Is there a problem that you're seeing that would make you think that the product needs to be touched?
@radar: I see, what if the master variant is updated (I know we should not touch master variant directly but I do in few occasions) so should it touch product?
IMHO, I think we should not care if it is master or not.
I don't see anything that could go wrong if we removed that restriction. Do the core tests still pass if you remove it?
@radar: I think so too. My opinion is not to enforce unnecessary rule. Have not yet run any test, but I think it should pass.
Updating master variant should also touch product