Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

per_item shipping calculator broken #1596

Closed
laurens opened this Issue · 4 comments

2 participants

@laurens

The fix for #1524 (commit c347351) breaks the PerItem calculator for shipping methods.

The target_products method refers to a promotion, which a ShippingMethod does not have.

Leads to error on checkout: "undefined method promotion"

@radar
Collaborator

Do you have some steps to reproduce this issue?

@laurens
  • i created a fresh spree install (1.1.1) without sample data
  • created a product and a dummy payment method
  • added a shipping method with per item shipping
  • put a product into the cart
  • checkout

saving the delivery screen fails with "undefined method promotion"

@radar
Collaborator

I have duplicated this issue in the tests committed to 1-1-stable and master. I will now revert #1524.

@radar radar closed this
@radar radar referenced this issue from a commit
@radar radar Revert "Per item calculator should only apply to matching products"
This reverts commit 93be6fa.

Reverted due to #1596
7b52fe3
@radar radar referenced this issue from a commit
@radar radar Revert "Per item calculator should only apply to matching products"
This reverts commit 93be6fa.

Reverted due to #1596
c82264f
@radar
Collaborator

This should now be fixed in both master and 1-1-stable with the commits titled "Re-add matching products limiter to per_item calculator" above.

Thanks for bringing this to our attention!

@radar radar referenced this issue from a commit
@radar radar Revert "Per item calculator should only apply to matching products"
This reverts commit 93be6fa.

Reverted due to #1596
c66dcc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.