Skip to content

Loading…

API returning deleted products #1626

Closed
Kagetsuki opened this Issue · 1 comment

2 participants

@Kagetsuki

Queries to api/products.json returns ALL products, including deleted ones. Writes against deleted products don't seem to happen, which is correct, but there is also no way to determine which products have been deleted and which are not currently deleted.

It seems to me api/products.json should not be returning deleted products - but if that is the intended behavior is there a way to filter them or identify them?

@radar radar added a commit that closed this issue
@radar radar Do not include deleted products by default
Allow them to be included by passing a show_deleted parameter

Fixes #1626
f4b232b
@radar radar closed this in f4b232b
@radar
Spree Commerce member

This has been fixed in 1-1-stable and master. You can get it show deleted products by passing a show_deleted parameter with any value if you wish.

@radar radar added a commit that referenced this issue
@radar radar Only allow admins to pass show_deleted parameter
Relates to #1626
25efab3
@radar radar added a commit that referenced this issue
@radar radar Only allow admins to pass show_deleted parameter
Relates to #1626
0d15f51
@radar radar added a commit that referenced this issue
@radar radar Only allow admins to pass show_deleted parameter
Relates to #1626
8c3f5a1
@cyu cyu pushed a commit to Scoutmob/spree that referenced this issue
@radar radar Do not include deleted products by default
Allow them to be included by passing a show_deleted parameter

Fixes #1626
4a75480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.