Skip to content
This repository

Support Twitter Bootstrap #1841

Closed
esfahani opened this Issue · 17 comments

9 participants

Matin Esfahani Ryan Bigg Coupling Washington L Braga Jr steve Peter Berkenbosch Michael Sevestre Jeff Dutil
Matin Esfahani

More and more, people are leaning towards using Twitter Bootstrap for developing websites. It's easy to use while providing GREAT functionality. Integrating that as part of Spree will make developing beautiful custom built e-commerce websites a breeze. Currently there is one gem that allows using Twitter Bootstrap for Spree projects to bridge the gap between Skeleton and Twitter Bootstrap. But it is very buggy and I don't see a reason why anyone would have to install an extension to Spree for using such a widely used tool.

I really hope to see Twitter Bootstrap support as part of Spree in the near future.

Ryan Bigg
Collaborator

Please see the red box under this section in the Contributing to Spree guide

Feature requests without accompanying code will be closed. We simply cannot respond efficiently to feature requests through our Issue Tracker. If you want to suggest a feature, please use the mailing list.

While I can see the appeal of using Twitter Bootstrap, it has not been asked for by a large portion of the community and therefore is not immediately a good use of our time.

Thanks for using Spree :)

Ryan Bigg radar closed this
Coupling

+1 for bootstrap, especially for the backend. While at it, include simple_form as well :)

Washington L Braga Jr
Collaborator

+1 one for just a better API which can be safe, stable and easily extensible. Spree has too many dependencies already. Add more and issues raise insanely fast.

steve

+1 for bootstrap! :)

Ryan Bigg
Collaborator
radar commented

This is an old issue, but it comes up when searching so for anyone who arrives here:

https://github.com/200Creative/spree_bootstrap_frontend

Is a frontend bootstrap 3 port for 2.2.x onwards.

Peter Berkenbosch
Collaborator

:+1:

Ryan Bigg
Collaborator

Thank you @200Creative. Is this is similar to @jdutil's https://github.com/jdutil/spree_bootstrap?

@radar as far as I'm aware that repo made a start on the idea, stripping out classes and adding bootstrap ones, but stalled a few months ago (though there are some forks that have been updated since none are merged) - I don't think it's production ready.

But the main reason I started this separately is because that repo is based on the older bootstrap 2 which is drastically different from bootstrap 3. Also I wanted to just use vanilla bootstrap, rather than the hybrid approach of leaving the store/screen & normalise in, then overriding it again manually. One of my main goals was the let people get away from the 1300+ lines of spree custom CSS. Also I wanted to set up a ground-up rework of the grid system to give good separate tablet and mobile grids.

I'm also planning on releasing a repo of 'single file' drop-in spree themes once I've got a 2-2-stable branch.

Ryan Bigg
Collaborator

@200Creative Sounds like an excellent plan :) Thank you again for all the hard work you've put into this. I really like the idea behind it.

Michael Sevestre
Jeff Dutil
Collaborator

Yea https://github.com/jdutil/spree_bootstrap was done for Spree 2.0.x and was an attempt to get the community behind a common bootstrap frontend. I haven't been able to update it for 2.1.x or bootstrap 3 so glad someones got to it for me. Thanks @200Creative.

Peter Berkenbosch
Collaborator

@peterberkenbosch I actually considered that originally, but I decided against it for one main reason: I really want this to be a full replacement for spree's frontend - rather than just something built 'ontop' of it. As it stands I've kept very close to the markup and structure, but as time goes on, there is so much potential to refector and improve the UI that I wouldn't want to be tied to spree's views. Even going through just setting up the grid there were so many areas that could do with ground-up reworks that I really think that there's better potential for more drastic improvements this way.

@msevestre As it stands there are 40 .html.erb files to be maintained. Generally spree's frontend changes very slowly compared to the rest of the project. Lots of these files don't change for months at a time. So initially I plan to just keep an eye on spree commits for any changes to the ruby outputs in views. If views markup changes I'm not so fussed as I don't see divergence as a problem as long as all functionality is maintained. If we get some uptake then the natural process of people patching for their own versions should help too.

@radar Thanks!

@jdutil My hope is that I can support this personally for long enough to get some uptake. I've been patching spree over to bootstrap per-project for so long that this makes better economic sense all round!

Peter Berkenbosch
Collaborator

I totally understand that @200Creative, I would suggest investing some time in filling the rspec folder to make sure stuff keeps on working :)

@peterberkenbosch yeah, that's pretty much number 1 on my list, and required before I release a -stable branch!

Jeff Dutil
Collaborator

@200Creative well I will probably begin pointing the 40 or so followers of my repo towards yours as well. I'd prefer to be going your route of a complete replacement, but I don't have the time or energy to maintain one myself as there has been little outside effort to patch my repo for new versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.