Duplicate ids in order_details partial in 1-3-stable #2836

Closed
linrock opened this Issue Apr 7, 2013 · 1 comment

2 participants

@linrock

Lines 46 and 55 both use an id of "line-items" in this file:
https://github.com/spree/spree/blob/1-3-stable/core/app/views/spree/shared/_order_details.html.erb

For reference:

  <thead id="line-items" data-hook>
    <tr data-hook="order_details_line_items_headers">
      <th colspan="2"><%= t(:item) %></th>
      <th class="price"><%= t(:price) %></th>
      <th class="qty"><%= t(:qty) %></th>
      <th class="total"><span><%= t(:total) %></span></th>
    </tr>
  </thead>

  <tbody id="line-items" data-hook>
@radar radar added a commit to radar/spree that referenced this issue Apr 8, 2013
@radar radar Remove invalid duplicate line-items id in shared/_order_details.html.erb
This has now been moved to the <table> tag which contains both these elements.

Fixes #2836
b70f5f8
@radar radar added a commit to radar/spree that referenced this issue Apr 8, 2013
@radar radar Remove invalid duplicate line-items id in shared/_order_details.html.erb
This has now been moved to the <table> tag which contains both these elements.

Fixes #2836
361ffb1
@radar
Spree Commerce member

Thanks for letting us know about this. I've got a fix in for this problem on my master, 1-3-stable and 1-2-stable branches. These should be merged to spree/spree by the end of this week.

@radar radar added a commit that referenced this issue Apr 8, 2013
@radar radar Remove invalid duplicate line-items id in shared/_order_details.html.erb
This has now been moved to the <table> tag which contains both these elements.

Fixes #2836
6beadca
@radar radar added a commit that closed this issue Apr 8, 2013
@radar radar Remove invalid duplicate line-items id in shared/_order_details.html.erb
This has now been moved to the <table> tag which contains both these elements.

Fixes #2836
5825a6f
@radar radar closed this in 5825a6f Apr 8, 2013
@radar radar added a commit to radar/spree that referenced this issue Apr 9, 2013
@radar radar Remove invalid duplicate line-items id in shared/_order_details.html.erb
This has now been moved to the <table> tag which contains both these elements.

Fixes #2836
da6f0a5
@vergeman vergeman pushed a commit that referenced this issue Jan 22, 2015
@radar radar Remove invalid duplicate line-items id in shared/_order_details.html.erb
This has now been moved to the <table> tag which contains both these elements.

Fixes #2836
f32682b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment