Not translatable: Reasonable Quantity & Out of Stock #2845

Closed
moonglum opened this Issue Apr 8, 2013 · 5 comments

Comments

Projects
None yet
2 participants
Contributor

moonglum commented Apr 8, 2013

It's not possible to localize the errors "Reasonable Quantity" and "Out of Stock" via i18n. The only way currently is to overwrite the entire file order_populator.rb, because the Strings are hardcoded. See here and here.

Member

radar commented Apr 8, 2013

Could you please submit a patch to fix this? That would be greatly
appreciated.

On Monday, April 8, 2013, Lucas Dohmen wrote:

It's not possible to localize the errors "Reasonable Quantity" and "Out of
Stock" via i18n. The only way currently is to overwrite the entire file
order_populator.rb, because the Strings are hardcoded. See herehttps://github.com/spree/spree/blob/master/core/app/models/spree/order_populator.rb#L44and
herehttps://github.com/spree/spree/blob/master/core/app/models/spree/order_populator.rb#L63


Reply to this email directly or view it on GitHubhttps://github.com/spree/spree/issues/2845
.

Ryan Bigg
Community Manager
Spree Commerce, Inc.

Register now for SpreeConf
May 20-21 in Washington, D.C.
http://spreeconf.com

Contributor

moonglum commented Apr 8, 2013

Yep, I'll send you a pull request sometime this week 😄

Member

radar commented Apr 9, 2013

Thank you! Ill check back Monday unless you ping me before then.

On Tue, Apr 9, 2013 at 4:59 AM, Lucas Dohmen notifications@github.com
wrote:

Yep, I'll send you a pull request sometime this week 😄

Reply to this email directly or view it on GitHub:
#2845 (comment)

Member

radar commented Apr 12, 2013

I had some spare cycles today and thought I would tackle this, and I did. Please check out the latest commits on my master/1-3-stable branches at radar/spree.

@radar radar closed this in a27c912 Apr 12, 2013

Contributor

moonglum commented Apr 12, 2013

Awesome Ryan, thank you so much! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment