New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin/address_states.js isn't precompiled #754
Comments
Which version of Spree are you using? We'll need to know to duplicate this issue. |
I use spree 0.70. My gem list is below:
|
Ah, you're using 0.70.0. We'd recommend updating to 0.70.1 which comes with faster asset compilation and may contain a fix for this issue as I am unable to duplicate it on my machine. |
i'm on 0.70.3 and i suffer from the same error when accessing order->customer details |
same issue on 0.70.4.beta |
same issue on 0.70.3 |
Please provide steps to reproduce this issue. |
I have the same thing on 0.70.3, just created an order and went to admin panel to look at it |
Hi @fuksito, please try pointing your app to 0-70-stable and giving that a shot. @ba956af2fb2e063a443bc0090177d3abded3a611 should have fixed this issue. |
I`ve just added config.assets.precompile += ['admin/address_states.js'] to my config and it solved the problem |
Whoops, my mistake. Now @1f3b443 in 0-70-stable branch should fix that. You don't need to that line in your config any more if you're using the latest ref of this branch. |
Great, thank you |
Looks like 1.0 never got this fix? |
If you add this to that precompile line, does it make it work? Would you be able to submit a patch to fix it? I am travelling for the next 20 hours and so I have very limited internet during that time. |
Yes, it does make it work. diff --git a/core/lib/spree/core/engine.rb b/core/lib/spree/core/engine.rb
index 44740ab..97e2af9 100644
--- a/core/lib/spree/core/engine.rb
+++ b/core/lib/spree/core/engine.rb
@@ -71,7 +71,7 @@ module Spree
# sets the manifests / assets to be precompiled
initializer "spree.assets.precompile" do |app|
- app.config.assets.precompile += ['store/all.*', 'admin/all.*', 'admin/orders/edit_form.js', 'jqPlot/excanvas.min.js', 'admin/images/new.js', 'jquery.j
+ app.config.assets.precompile += ['store/all.*', 'admin/all.*', 'admin/orders/edit_form.js', 'admin/orders/address_states.js', 'jqPlot/excanvas.min.js'
end
initializer "spree.asset.pipeline" do |app| |
This should be fixed with @56dc7c8 now on master, and @71f7dff on 1-0-stable. Thanks guys! |
Changing path in assets.precompile is not enough. This file still references the old path (admin/address_states.js). And that file is not in admin/orders, but still at admin/. I have fixed it on my fork but created branch off 1-0-stable. Should i recreate it from master before pull request? |
This error return when I go to order -> customer details
I fix it with adding assets.precompile in config/application.rb.
The text was updated successfully, but these errors were encountered: