GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When deleting a product in the admin interface it leaves the master variant live (ie doesn't set the delete_at for it)
It goes through the variants, when it should go through variants_including master.
I don't understand this. Where does it go through the variants? Where should it go through variants_including_master instead?
@radar Sorry: in Admin::ProductsController.destroy
though it is arguable that the code should actually be in Product, and the controller should just call product.delete
Fixed, thanks for pointing this out!