New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product delete leaves master #801

Closed
rubydesign opened this Issue Nov 20, 2011 · 3 comments

Comments

Projects
None yet
2 participants
@rubydesign

rubydesign commented Nov 20, 2011

When deleting a product in the admin interface it leaves the master variant live (ie doesn't set the delete_at for it)

It goes through the variants, when it should go through variants_including master.

@radar

This comment has been minimized.

Show comment
Hide comment
@radar

radar Nov 22, 2011

Member

I don't understand this. Where does it go through the variants? Where should it go through variants_including_master instead?

Member

radar commented Nov 22, 2011

I don't understand this. Where does it go through the variants? Where should it go through variants_including_master instead?

@rubydesign

This comment has been minimized.

Show comment
Hide comment
@rubydesign

rubydesign Nov 22, 2011

@radar Sorry: in Admin::ProductsController.destroy

though it is arguable that the code should actually be in Product, and the controller should just call product.delete

rubydesign commented Nov 22, 2011

@radar Sorry: in Admin::ProductsController.destroy

though it is arguable that the code should actually be in Product, and the controller should just call product.delete

@radar radar closed this in b9ec325 Nov 23, 2011

@radar

This comment has been minimized.

Show comment
Hide comment
@radar

radar Nov 23, 2011

Member

Fixed, thanks for pointing this out!

Member

radar commented Nov 23, 2011

Fixed, thanks for pointing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment