Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Clear Shipment when go back to 'address' or 'delivery' from other states in Order checkout #925

Closed
joneslee85 opened this Issue · 1 comment

2 participants

Trung Lê John Dyer
Trung Lê
Collaborator

I found an interesting bug with the way Spree store order shipping_method_id and shipment_state in state_machine.

  • Given your address zone is North America

    • You choose UPS Standard $5.00 at Delivery step
  • Given you are at Payment step

    • You go back to Address step and change your country to European zone

    • Given new list of shipment options in Delivery step (let's make it up, something like FedEx Standard $53.00)

      • You don't check / choose any of these options and Continue to Payment step

      Results:

      • No errors complaining about you have not yet chosen a shipping method
      • Shipping method is still set to UPS Standard $5.00

      Expectation:

      • Errors on No method is chosen

IMHO, we should have a callback for the transition from any state but 'address' and 'delivery' to 'address' or 'delivery' to clear the shipment or shipment adjustment of the order. By doing so, we ensure that order always reflect the right Summary details in every single checkout step.

John Dyer LBRapid was assigned
John Dyer LBRapid referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
John Dyer LBRapid referenced this issue from a commit in LBRapid/spree
John Dyer LBRapid [Fixes #925] Clear shipment when transitioning to delivery step of
checkout if the current shipping address is not eligible for the
existing shipping method
8b4899a
John Dyer LBRapid closed this issue from a commit
John Dyer LBRapid [Fixes #925] Clear shipment when transitioning to delivery step of
checkout if the current shipping address is not eligible for the
existing shipping method
6d0e772
John Dyer LBRapid closed this in 6d0e772
Bèr Kessels berkes referenced this issue from a commit
Bèr Kessels Merge branch 'master' of github.com:berkes/spree
* 'master' of github.com:berkes/spree:
  Version bump
  type conversions for preferences. changed the value_types stored in the database. temporary conversion for preferences created during 1.0 release candidates. [Fixes #1117]
  Fix legacy preference migration
  Fixed checkout_spec
  [Fixes #925] Clear shipment when transitioning to delivery step of checkout if the current shipping address is not eligible for the existing shipping method
37bab0c
Trung Lê joneslee85 reopened this
Trung Lê
Collaborator

I re-open the issue is still relevant on master branch

John Dyer LBRapid closed this issue from a commit
John Dyer LBRapid [Fixes #925] Clear shipment when transitioning to delivery step of
checkout if the current shipping address is not eligible for the
existing shipping method
093bddb
John Dyer LBRapid closed this in 093bddb
David Demers fonemstr referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
Bounmy Stéphane sbounmy referenced this issue from a commit in sbounmy/spree
John Dyer LBRapid Clear shipment when transitioning to delivery step of
checkout if the current shipping address is not eligible for the
existing shipping method

[Fixes #925]
2af082d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.