Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Set overflow to hidden for long product titles. #1252

Closed
wants to merge 1 commit into from

2 participants

@JDutil
Collaborator

Even though we are truncating the titles now depending on how long certain words are the word wrap can still cause the titles to flow into 3 lines behind the price. The current truncation length is good for a majority of titles, but some edge cases need to be hidden.

@JDutil
Collaborator

Was also just looking at a site on an iPhone, and this becomes more important as most product names overflow on the smaller smartphone screens.

@schof
Owner

@devilcoders Are you ok with this change?

@schof schof closed this in 9a1234f
@nesquena nesquena referenced this pull request from a commit in nesquena/spree
@JDutil JDutil Set overflow to hidden for long product titles.
[Fixes #1252]
6f4a3ee
@tvdeyen tvdeyen referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@tvdeyen tvdeyen referenced this pull request from a commit in magiclabs/spree
@JDutil JDutil Set overflow to hidden for long product titles.
[Fixes #1252]
20b3ead
@fonemstr fonemstr referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 10, 2012
  1. @JDutil
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 0 deletions.
  1. +1 −0  core/app/assets/stylesheets/store/screen.css.scss
View
1  core/app/assets/stylesheets/store/screen.css.scss
@@ -513,6 +513,7 @@ mark {background-color: $link_text_color; color: $layout_background_color; font-
font-size: $product_list_name_font_size;
color: $product_link_text_color;
border-bottom: 1px solid lighten($body_text_color, 60);
+ overflow: hidden;
}
}
Something went wrong with that request. Please try again.