Join GitHub today
Isolation of components during testing #1296
There was an issue (#1292) brought up yesterday where Spencer attempted to run tests for an extension only to run into an issue where we were referencing
To ensure that something like this never comes up again, I've taken the time to separate the testing of the individual components of Spree and have run the tests to determine if there were any more places where issues like #1292 would come up. There were, and they have been fixed.
When the build passes for the isolation branch on Travis, it should be good to merge this in... providing that everyone agrees that this is the way forward.
referenced this pull request
Mar 20, 2012
Based on a discussion I had with Sean yesterday, these changes probably won't make it into 1-0-stable, but will be applied directly to master -- and therefore contribute to the 1-1-stable release. A patch release, in our opinion, should not introduce so many large changes like this.
The patch cmar gave to fix the issue will be released in 1.0.4, meaning your extensions tests should work on that version. We'll be making sure of that before we do a release.
We'll be releasing 1-1-stable later this week most likely.
added a commit
this pull request
Mar 21, 2012
pushed a commit
this pull request
Apr 5, 2012
The issue I'm still seeing is issue #1292 (current_user method error)
I'll test against the 1-0-stable branch in the future, but it would be nice if the spree team tested new versions against some popular extensions before they are released as well.
On another note, 1.1.0 is working great without any breakage. Thanks!!
@radar well, you said
So I was basically waiting for 1.0.4 release..I will also test again 1-0-stable in the future.