Skip to content

Loading…

added jquery.js and jquery_ujs.js to assets pipeline #1421

Closed
wants to merge 4 commits into from

2 participants

@wandtasie

these files aren't precompiled and after changes related to
#1404
dynamical included

this causes error 500 in production

Edit: we need this in both: master and 1-1-stable

Matthias Wagner added some commits
Matthias Wagner added jquery to assets pipeline aa6a832
Matthias Wagner forgot .js 5cb5c4f
Matthias Wagner next try 37b2cab
Matthias Wagner updated path 2857287
@radar
Spree Commerce member

Please update the pull request to reflect the latest changes in master.

@radar
Spree Commerce member

I don't see any need to do this, as both the homepage and the admin overview are working for me in production. What's breaking for you?

@radar radar added a commit that referenced this pull request
@radar radar Move jquery and jquery_ujs out of shared/_head and into admin/all.js …
…and store/all.js so that they're precompiled

Related to #1404, negates the need for #1421
5f5b351
@radar radar added a commit that referenced this pull request
@radar radar Move jquery and jquery_ujs out of shared/_head and into admin/all.js …
…and store/all.js so that they're precompiled

Related to #1404, negates the need for #1421
9aed012
@radar
Spree Commerce member

I think this is fixed with the latest commits to 1-1-stable and master now. I have moved the dependencies for jquery back to store/all.js and admin/all.js and cannot reproduce #1404 again.

@radar radar closed this
@radar radar added a commit that referenced this pull request
@radar radar Move jquery and jquery_ujs out of shared/_head and into admin/all.js …
…and store/all.js so that they're precompiled

Related to #1404, negates the need for #1421
d8b5f79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 19, 2012
  1. added jquery to assets pipeline

    Matthias Wagner committed
  2. forgot .js

    Matthias Wagner committed
  3. next try

    Matthias Wagner committed
  4. updated path

    Matthias Wagner committed
Showing with 1 addition and 1 deletion.
  1. +1 −1 core/lib/spree/core/engine.rb
View
2 core/lib/spree/core/engine.rb
@@ -71,7 +71,7 @@ def self.activate
# sets the manifests / assets to be precompiled
initializer "spree.assets.precompile" do |app|
- app.config.assets.precompile += ['store/all.*', 'admin/all.*', 'admin/orders/edit_form.js', 'admin/address_states.js', 'jqPlot/excanvas.min.js', 'admin/images/new.js', 'jquery.jstree/themes/apple/*']
+ app.config.assets.precompile += ['store/all.*', 'admin/all.*', 'admin/orders/edit_form.js', 'admin/address_states.js', 'jqPlot/excanvas.min.js', 'admin/images/new.js', 'jquery.jstree/themes/apple/*', 'jquery.js', 'jquery_ujs.js']
end
initializer "spree.mail.settings" do |app|
Something went wrong with that request. Please try again.