Skip to content
This repository

Use phone_field helper for semantic markup. #1556

Closed
wants to merge 1 commit into from

2 participants

Jeff Dutil Sean Schofield
Jeff Dutil
Collaborator
JDutil commented May 17, 2012

No description provided.

Sean Schofield
Owner
schof commented on c173518 May 17, 2012

Good idea!

Sean Schofield schof closed this in 55bacb2 May 17, 2012
Thomas von Deyen tvdeyen referenced this pull request from a commit in magiclabs/spree May 17, 2012
Jeff Dutil Use phone_field helper for semantic markup.
[Fixes #1556]
7f573d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

May 17, 2012
Jeff Dutil Use phone_field helper for semantic markup. c173518
This page is out of date. Refresh to see the latest.
2  core/app/views/spree/admin/shared/_address_form.html.erb
@@ -71,7 +71,7 @@
71 71
       <td class="lbl-col">
72 72
         <%= f.label :phone, t(:phone) + ':' %>
73 73
       </td>
74  
-      <td colspan="7"><%= f.text_field :phone %></td>
  74
+      <td colspan="7"><%= f.phone_field :phone %></td>
75 75
     </tr>
76 76
   </tbody>
77 77
 </table>
8  core/app/views/spree/checkout/_address.html.erb
@@ -68,12 +68,12 @@
68 68
       </p>
69 69
       <p class="field" id="bphone">
70 70
         <%= bill_form.label :phone, t(:phone) %><span class="req">*</span><br />
71  
-        <%= bill_form.text_field :phone, :class => 'required' %>
  71
+        <%= bill_form.phone_field :phone, :class => 'required' %>
72 72
       </p>
73 73
       <% if Spree::Config[:alternative_billing_phone] %>
74 74
         <p class="field" id="baltphone">
75 75
           <%= bill_form.label :alternative_phone, t(:alternative_phone) %><br />
76  
-          <%= bill_form.text_field :alternative_phone %>
  76
+          <%= bill_form.phone_field :alternative_phone %>
77 77
         </p>
78 78
       <% end %>
79 79
     </div>
@@ -155,12 +155,12 @@
155 155
       </p>
156 156
       <p class="field" id="sphone">
157 157
         <%= ship_form.label :phone, t(:phone) %><span class="req">*</span><br />
158  
-        <%= ship_form.text_field :phone, :class => 'required' %>
  158
+        <%= ship_form.phone_field :phone, :class => 'required' %>
159 159
       </p>
160 160
       <% if Spree::Config[:alternative_shipping_phone] %>
161 161
         <p class="field" id="saltphone">
162 162
           <%= ship_form.label :alternative_phone, t(:alternative_phone) %><br />
163  
-          <%= ship_form.text_field :alternative_phone %>
  163
+          <%= ship_form.phone_field :alternative_phone %>
164 164
         </p>
165 165
       <% end %>
166 166
     </div>
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.