Add devise to fix dummy db seed/migration #1573

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

jeebster commented May 21, 2012

This is all-encompassing of issues such as #1544 and #1545. Devise 2.0.x should be a common dependency to prevent test_app breakage

Member

radar commented May 21, 2012

I don't think that Devise should be a common spree dependency. It should only be a dependency of auth. When we take out auth (with all the changes from #1512), having this in the common spree dependency list will interfere.

radar closed this May 21, 2012

Contributor

jeebster commented May 21, 2012

Ah, my bad. You are correct, only the auth devise dependency is breaking the test_app.

Member

radar commented May 21, 2012

How is it breaking it though? If it was breaking it, wouldn't we be getting errors on Travis?

Contributor

jeebster commented May 21, 2012

User error :) My branch was a wee bit behind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment