New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing spec for issue #1917 #1974

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@ehoch
Contributor

ehoch commented Sep 16, 2012

Products appearing in multiple children of a taxon are duplicated in the parent when using the in_taxon product scope...

@radar

This comment has been minimized.

Show comment
Hide comment
@radar

radar Sep 17, 2012

Member

The fix for this is in #1962, but it causes other side-effects.

Member

radar commented Sep 17, 2012

The fix for this is in #1962, but it causes other side-effects.

@radar radar closed this in 8a303e1 Oct 18, 2012

radar added a commit that referenced this pull request Oct 18, 2012

Fix multiple products from appearing when using Product.in_taxons scope
Fixes #1917

Fixes #1974

Fixes #1962

Conflicts:

	core/app/models/spree/product/scopes.rb
	core/spec/models/product/scopes_spec.rb

radar added a commit that referenced this pull request Oct 18, 2012

Fix multiple products from appearing when using Product.in_taxons scope
Fixes #1917

Fixes #1974

Fixes #1962

Conflicts:

	core/app/models/spree/product/scopes.rb
	core/spec/models/product/scopes_spec.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment