New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added available? method to Product #2002

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@laurens
Contributor

laurens commented Sep 22, 2012

No description provided.

@radar

This comment has been minimized.

Show comment
Hide comment
@radar

radar Sep 23, 2012

Member

Is there anywhere inside Spree that could use this method? It'd be useful to replace occurrences where available_at is manually compared?

On 23/09/2012, at 0:38, laurens notifications@github.com wrote:

You can merge this Pull Request by running:

git pull https://github.com/laurens/spree available
Or view, comment on, or merge it at:

#2002

Commit Summary

Added available? method to product
File Changes

M core/app/models/spree/product.rb (4)
Patch Links

https://github.com/spree/spree/pull/2002.patch
https://github.com/spree/spree/pull/2002.diff

Reply to this email directly or view it on GitHub.

Member

radar commented Sep 23, 2012

Is there anywhere inside Spree that could use this method? It'd be useful to replace occurrences where available_at is manually compared?

On 23/09/2012, at 0:38, laurens notifications@github.com wrote:

You can merge this Pull Request by running:

git pull https://github.com/laurens/spree available
Or view, comment on, or merge it at:

#2002

Commit Summary

Added available? method to product
File Changes

M core/app/models/spree/product.rb (4)
Patch Links

https://github.com/spree/spree/pull/2002.patch
https://github.com/spree/spree/pull/2002.diff

Reply to this email directly or view it on GitHub.

@laurens

This comment has been minimized.

Show comment
Hide comment
@laurens

laurens Sep 23, 2012

Contributor

I found one occurrence in spree_auth_device, see this: spree/spree_auth_devise#18

Contributor

laurens commented Sep 23, 2012

I found one occurrence in spree_auth_device, see this: spree/spree_auth_devise#18

@radar

This comment has been minimized.

Show comment
Hide comment
@radar

radar Sep 24, 2012

Member

Alright then. I think we'll leave that one be for people who aren't on the latest version of Spree.

Member

radar commented Sep 24, 2012

Alright then. I think we'll leave that one be for people who aren't on the latest version of Spree.

@radar radar closed this in ad17631 Sep 24, 2012

radar added a commit that referenced this pull request Sep 24, 2012

radar added a commit that referenced this pull request Sep 24, 2012

@laurens laurens deleted the laurens:available branch Jan 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment