New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage currency whose subunit is not 100 (like JPY) #2030

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@kei-s
Contributor

kei-s commented Oct 1, 2012

With Money.gem,

Money.new(1000, "JPY").format #=> "¥1,000"

But with Spree::Money,

Spree::Config[:currency] #=> "JPY"
Spree::Money.new(1000).to_s #=> "¥100,000"

I fixed it to provide same result as Money.gem.

@joneslee85 joneslee85 closed this in e4dda3c Oct 1, 2012

@joneslee85

This comment has been minimized.

Show comment
Hide comment
@joneslee85

joneslee85 Oct 1, 2012

Member

@kei-s thanks for your contribution

Member

joneslee85 commented Oct 1, 2012

@kei-s thanks for your contribution

@kei-s

This comment has been minimized.

Show comment
Hide comment
@kei-s

kei-s Oct 2, 2012

Contributor

😃

Contributor

kei-s commented Oct 2, 2012

😃

@kei-s

This comment has been minimized.

Show comment
Hide comment
@kei-s

kei-s Oct 2, 2012

Contributor

Will you backport this to 1-2-stable branch?
And will you have plan to release 1.2.1 or greater? Sorry for this question is not suitable here.

Contributor

kei-s commented Oct 2, 2012

Will you backport this to 1-2-stable branch?
And will you have plan to release 1.2.1 or greater? Sorry for this question is not suitable here.

@radar

This comment has been minimized.

Show comment
Hide comment
@radar

radar Oct 2, 2012

Member

This has now been backported to the 1-2-stable branch.

We will release 1.2.1 "soon-ish". I think we've got enough commits there to warrant a point release.

Member

radar commented Oct 2, 2012

This has now been backported to the 1-2-stable branch.

We will release 1.2.1 "soon-ish". I think we've got enough commits there to warrant a point release.

radar added a commit that referenced this pull request Oct 2, 2012

@kei-s

This comment has been minimized.

Show comment
Hide comment
@kei-s

kei-s Oct 2, 2012

Contributor

Thanks. 😄
I'm waiting to use 1.2.1 soon!

Contributor

kei-s commented Oct 2, 2012

Thanks. 😄
I'm waiting to use 1.2.1 soon!

radar added a commit that referenced this pull request Oct 4, 2012

huoxito added a commit to huoxito/spree that referenced this pull request Nov 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment