New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update order before redirecting to checkout #2086

Closed
wants to merge 2 commits into
base: 1-2-stable
from

Conversation

Projects
None yet
3 participants
@LBRapid
Member

LBRapid commented Oct 15, 2012

When clicking 'Checkout' on the cart page, any changes made to the order will not e saved unless 'Update' is clicked first, updating the order.

I propose we update the 'Checkout' button to also update the order. This way, any last minute changes will be preserved while a user is attempting to checkout.

I am putting this up for discussion at the moment. You will notice I added this code to promo rather than core. This is because promo overrides the update action on Spree::OrdersController. I think this is something that could use some clean up as well.

Thanks

@LBRapid LBRapid closed this in 3082039 Oct 15, 2012

@radar

This comment has been minimized.

Show comment
Hide comment
@radar

radar Oct 15, 2012

Member

Applied to 1-2-stable and master. Thanks!

Member

radar commented Oct 15, 2012

Applied to 1-2-stable and master. Thanks!

LBRapid added a commit that referenced this pull request Oct 15, 2012

@JDutil

This comment has been minimized.

Show comment
Hide comment
@JDutil

JDutil Oct 15, 2012

Member

🤘 @LBRapid great idea to help the user experience. I think this should be done in the Core controller also though in case the application isn't using Promo.

Member

JDutil commented Oct 15, 2012

🤘 @LBRapid great idea to help the user experience. I think this should be done in the Core controller also though in case the application isn't using Promo.

@radar

This comment has been minimized.

Show comment
Hide comment
@radar

radar Oct 16, 2012

Member

@JDutil It needs to be done in both, because of how promo overrides the update action. I'm going to apply a patch to core for this in a sec.

Member

radar commented Oct 16, 2012

@JDutil It needs to be done in both, because of how promo overrides the update action. I'm going to apply a patch to core for this in a sec.

radar added a commit that referenced this pull request Oct 16, 2012

radar added a commit that referenced this pull request Oct 16, 2012

Go to checkout state page when checkout button is clicked
Fixes #2086

Conflicts:

	core/spec/requests/checkout_spec.rb
@radar

This comment has been minimized.

Show comment
Hide comment
@radar

radar Oct 16, 2012

Member

Those latest commits will fix the core controller.

Member

radar commented Oct 16, 2012

Those latest commits will fix the core controller.

@JDutil

This comment has been minimized.

Show comment
Hide comment
@JDutil

JDutil Oct 16, 2012

Member

Thanks!

Member

JDutil commented Oct 16, 2012

Thanks!

radar added a commit that referenced this pull request Oct 16, 2012

radar added a commit that referenced this pull request Oct 16, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment