Refactor taxonomy js tree as mentioned in #2129

[codeodor]

No description provided.

[codeodor]

Just a note: I chose to do this on the 1-2-stable branch instead of master, because I am more familiar with it, plus I was having trouble getting tests and a dummy site running on master when I tried there first (before making any changes).

[derfarg]

@codeodor im using 1-2-stable in our productive client shops and in all of this. The js tree in admin dont work. This job is done?

[codeodor]

Wow, I didn't get this notification via email ... just saw it now, so sorry for the big delay in response!

Yes, I believe it should be done. The tests were passing and it's working on my installation...

What issue were you experiencing? Maybe a description will help me figure out what's wrong?

PS: Just to be clear, the issue you were having is with 1-2-stable as-is, or with the code I am requesting be merged here? If the issue you're having is with 1-2-stable as it exists before these commits, I doubt these commits will help. (But I'd be willing to look at the issue anyway and see if I can lend a hand in fixing it)

[iloveitaly]

It seems like a apostrophe in the name will cause the tree to break.

[codeodor]

Thanks for the insight. I'm heading out of town for a conference where I don't think I'll get any free time to look, but I'll create a fix for the problem when I get back at the end of next week.

[radar]

@iloveitaly: Still? Even in 1-3-stable and master?

[radar]

I am hesitant to merge this pull request because I've already done some refactoring for it within the split_core branch; notably, moving the responsibility of generating the JSON hash to the API, rather than having it in the view or in the model.

Is there anything else this PR addresses?

[iloveitaly]

@radar Not sure about 1-3-stable or master... I'm working off of 1-2-stable right now. Could this fix be backported onto 1-2-stable?

[codeodor]

@radar - The only other important thing this PR does aside from move the JSON generation is refactor the JS from straight js in a script tag to be called from a function, thereby making the code usable in other places.

When I get back to work, I could look through the split_core branch and do it there instead if you'd rather just close this one.

[radar]

Yes. Please look through the changes on split_core and see if you can
improve the code there.

On Tue, Feb 5, 2013 at 6:54 AM, Sammy Larbi notifications@github.comwrote:

@radar https://github.com/radar - The only other important thing this
PR does aside from move the JSON generation is refactor the JS from
straight js in a script tag to be called from a function, thereby making
the code usable in other places.

When I get back to work, I could look through the split_core branch and do
it there instead if you'd rather just close this one.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2192#issuecomment-13095720.