Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various API Improvements #2198

Closed
wants to merge 16 commits into from
Closed

Various API Improvements #2198

wants to merge 16 commits into from

Conversation

LBRapid
Copy link
Member

@LBRapid LBRapid commented Nov 9, 2012

Made some changes/improvements to the API controllers

  • All controllers that have an index action now accept a page and per_page parameter to filter results
  • All controllers that have an index action now accept the ransack query parameter for searching purposes
  • Controllers with a separate index/seach now just have index, as searching functionality has been merged into that action.

All specs are updated as well. API documentation updates to come.

@LBRapid LBRapid closed this in c013a89 Nov 11, 2012
LBRapid added a commit that referenced this pull request Nov 11, 2012
* Merge search/index actions of API's OrderController
* Add searching ability to API's CountriesController
* Allow pages and per_page parameters to be passed to Countries
* Add count node to payments index action
* Allow pages and per_page parameters to be passed to Payments
* Add searching ability to API's PaymentsController
* Allow pages and per_page parameters to be passed to ProductProperties
* Add searching ability to API's ProductPropertiesController
* Merge search/index actions of API's ProductsController
* Allow per_page parameter to be passed to Products
* Add search and allow per_page parameter to be passed to ReturnAuthorizations
* Allow pages and per_page parameters to be passed to Taxonomies
* Add searching ability to API's TaxonomiesController
* Add search and allow per_page parameter to be passed to Variants
* Allow pages and per_page parameter to be passed to API's Zones
* Add searching ability to API's ZonesController

Closes #2198
@radar
Copy link
Contributor

radar commented Nov 11, 2012

Excellent. Brian and I were just talking about this last week. Thanks for doing the changes so quickly. I look forward to the documentation updates as well.

@radar radar reopened this Nov 11, 2012
@radar radar closed this Nov 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants