New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding of shipping method’s adjustment label #2222

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@laurens
Contributor

laurens commented Nov 16, 2012

Allow overriding of a shipping method’s adjustment label.

Useful in cases where the name of the adjustment is not necessarily the same as the shipping method’s name.

In my case I override def adjustment_label in order to read the label value from the database.

@radar

This comment has been minimized.

Show comment
Hide comment
@radar

radar Nov 20, 2012

Member

This PR breaks tests within Travis. Please fix the failing tests.

Member

radar commented Nov 20, 2012

This PR breaks tests within Travis. Please fix the failing tests.

@radar radar closed this in ca277bd Dec 4, 2012

radar added a commit that referenced this pull request Dec 4, 2012

radar added a commit that referenced this pull request Dec 4, 2012

radar added a commit that referenced this pull request Dec 4, 2012

@radar

This comment has been minimized.

Show comment
Hide comment
@radar

radar Dec 4, 2012

Member

I've pulled this in now and have added some commits to fix up the tests.

Member

radar commented Dec 4, 2012

I've pulled this in now and have added some commits to fix up the tests.

@laurens laurens deleted the laurens:adjustment_label branch Jan 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment