Skip to content

Use line_item price instead of variant price in return_authorization - #2342

Closed
sanemat wants to merge 1 commit into
spree:masterfrom
sanemat:return-authorization
Closed

sanemat wants to merge 1 commit into
spree:masterfrom
sanemat:return-authorization

Conversation

@sanemat

@sanemat sanemat commented Dec 19, 2012

Copy link
Copy Markdown
Contributor

The case of return authorization, not variant.price but line_items.first.price to use.

@radar

radar commented Dec 20, 2012

Copy link
Copy Markdown
Contributor

I don't understand why this pull request is necessary. In what case would you want to be returning an entire line item rather than just one item contained within that line item?

@radar radar closed this Dec 20, 2012
@sanemat

sanemat commented Dec 21, 2012

Copy link
Copy Markdown
Contributor Author

In admin/orders/_form, admin/shared/_order_details, admin/orders/_add_product use line_items(price at the time), but admin/return_authorizations/_form uses current variant price, I want to use price at the time in return authorization case.
inventory unit does not have price at the time, line item has price at the time.

@radar radar reopened this Dec 21, 2012
@radar

radar commented Dec 21, 2012

Copy link
Copy Markdown
Contributor

Ok, I see your point now. Thanks for explaining it.

@radar radar closed this in 587599d Jan 2, 2013
radar pushed a commit that referenced this pull request Jan 2, 2013
@sanemat
sanemat deleted the return-authorization branch November 1, 2013 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants