Use line_item price instead of variant price in return_authorization #2342

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@sanemat
Contributor

sanemat commented Dec 19, 2012

The case of return authorization, not variant.price but line_items.first.price to use.

@radar

This comment has been minimized.

Show comment
Hide comment
@radar

radar Dec 20, 2012

Member

I don't understand why this pull request is necessary. In what case would you want to be returning an entire line item rather than just one item contained within that line item?

Member

radar commented Dec 20, 2012

I don't understand why this pull request is necessary. In what case would you want to be returning an entire line item rather than just one item contained within that line item?

@radar radar closed this Dec 20, 2012

@sanemat

This comment has been minimized.

Show comment
Hide comment
@sanemat

sanemat Dec 21, 2012

Contributor

In admin/orders/_form, admin/shared/_order_details, admin/orders/_add_product use line_items(price at the time), but admin/return_authorizations/_form uses current variant price, I want to use price at the time in return authorization case.
inventory unit does not have price at the time, line item has price at the time.

Contributor

sanemat commented Dec 21, 2012

In admin/orders/_form, admin/shared/_order_details, admin/orders/_add_product use line_items(price at the time), but admin/return_authorizations/_form uses current variant price, I want to use price at the time in return authorization case.
inventory unit does not have price at the time, line item has price at the time.

@radar radar reopened this Dec 21, 2012

@radar

This comment has been minimized.

Show comment
Hide comment
@radar

radar Dec 21, 2012

Member

Ok, I see your point now. Thanks for explaining it.

Member

radar commented Dec 21, 2012

Ok, I see your point now. Thanks for explaining it.

@radar radar closed this in 587599d Jan 2, 2013

radar added a commit that referenced this pull request Jan 2, 2013

@sanemat sanemat deleted the sanemat:return-authorization branch Nov 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment