New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with duplicate thumbnails on ProductController#show #2361

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@iloveitaly
Member

iloveitaly commented Dec 28, 2012

Spree 1.1.4 changes the way thumbnails were displayed. I didn't look into what exactly changed, but I think Product#images and Product#variant_images both returned the master variant image. This makes sense, but the thumbnail's partial was not updated to reflect this – in my case I was getting duplicate thumbnail display. This PR fixed the duplicate thumbnail display issue and cleans up the thumbnails partial.

Also, there were references to both @product and product, I switched to using the instance variable for consistency's sake.

This applies to master, 1-2-stable, and 1-1-stable.

@radar

This comment has been minimized.

Show comment
Hide comment
@radar

radar Jan 1, 2013

Member

I will only be applying this patch to master, 1-3-stable and 1-2-stable, as those are the only versions of Spree that we are maintaining now. Unless there's a security bug in 1-1-stable, we won't be patching it any further.

Member

radar commented Jan 1, 2013

I will only be applying this patch to master, 1-3-stable and 1-2-stable, as those are the only versions of Spree that we are maintaining now. Unless there's a security bug in 1-1-stable, we won't be patching it any further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment