Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Prototype properties ordering behavior and select fix. #2389
This is more or less two issues (behavior+fix) in one which I believe are related.
Firstly, there is a bug in product properties when selecting a prototype. It will only populate the last field and the rest of the fields will be blank. We just needed to change :last to :first selector.
Secondly, when creating a new prototype and populating them with properties, then updating (saving), the order in which they were added will be lost and they will be ordered by name. IMHO, this defeats the purpose of prototype properties, as most people will want to have them in a particular order as they were added, especially if there are many of them. So I removed the name order for properties, and also added some sorting logic to select.js.erb so that they are properly populated in the correct order.
I am not sure if this is an elegant fix, but it has been working perfectly for me, and I believe makes it more consistent in behavior.
Looking forward to feedback on this.